Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uefi plugin #1143

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Uefi plugin #1143

wants to merge 11 commits into from

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Oct 16, 2023

  • new analysis plugin based on FwHunt
    • convert to V0
    • write tests

@jstucke jstucke self-assigned this Oct 16, 2023
@jstucke jstucke marked this pull request as ready for review October 17, 2023 12:39
run_docker_container(
DOCKER_IMAGE,
combine_stderr_stdout=True,
timeout=self.TIMEOUT,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is part of the Mixin and should not be used.
Also I'd rather use functions instead of methods since plugins don't maintain state.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I didn't intend to use it. This is more of an artifact from the pre-V1 plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants